Skip to content

Conversation

@madotto
Copy link
Contributor

@madotto madotto commented Mar 2, 2017

  • An XML comment node as parameter in widget.xml fails with fatal error
  • Fixed also for comments in containers node too

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 2, 2017

CLA assistant check
All committers have signed the CLA.

- An XML comment node as parameter in widget.xml fails with fatal error
- Fixed also for comments in containers node
@madotto madotto force-pushed the magento/magento2#3882 branch from 4cca755 to 51da3d4 Compare March 2, 2017 17:38
@ishakhsuvarov ishakhsuvarov self-assigned this Mar 2, 2017
@okorshenko okorshenko self-assigned this Mar 2, 2017
@okorshenko okorshenko added this to the March 2017 milestone Mar 2, 2017
@ishakhsuvarov
Copy link
Contributor

@madotto Proposed fix has been merged to the develop branch. Thanks for contributing!
Sadly, the last commit you have done was not merged, so PR looks like Closed on github. All of the initial commits are merged.

hostep pushed a commit to hostep/magento2 that referenced this pull request Mar 20, 2018
magento#3882:
- An XML comment node as parameter in widget.xml fails with fatal error
- Fixed also for comments in containers node

(cherry picked from commit 51da3d4)

MAGETWO-65436: [GitHub][PR] magento#3882 magento#8772

(cherry picked from commit 03c9c20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants