Allow comments in widget.xml parameters #7439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
This issue was fixed in #8772 |
4 tasks
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Mar 14, 2022
Hammer bugfix delivery 02022022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Magento crashes in case if you have comments inside parameters section of widget.xml
(issue also reported here 3882)
Steps to reproduce
<parameters><!-- any comment --</parameters>)PHP Fatal error: Call to a member function getNamedItem() on null in /vagrant/vendor/magento/module-widget/Model/Config/Converter.php on line 54