Skip to content

Fatal error on cms block grid delete. #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fatal error on cms block grid delete. #8418

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a50dfa
Create a _getAllIdsSelect method in the block collection
dmanners Feb 4, 2017
bb10517
Move _getAllIdsSelect into the grid collection
dmanners Feb 4, 2017
5565e05
Remove the getAllIds as this is now on the parent collection class
dmanners Feb 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions app/code/Magento/Cms/Model/ResourceModel/Block/Grid/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,6 @@ public function setAggregations($aggregations)
$this->aggregations = $aggregations;
}

/**
* Retrieve all ids for collection
* Backward compatibility with EAV collection
*
* @param int $limit
* @param int $offset
* @return array
*/
public function getAllIds($limit = null, $offset = null)
{
return $this->getConnection()->fetchCol($this->_getAllIdsSelect($limit, $offset), $this->_bindParams);
}

/**
* Get search criteria.
*
Expand Down