Skip to content

Fatal error on cms block grid delete. #8418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fatal error on cms block grid delete. #8418

wants to merge 3 commits into from

Conversation

@dmanners
Copy link
Contributor

@dmanners dmanners commented Feb 4, 2017 •
edited by okorshenko
Loading

See #8415 for more information on how to reproduce.

On the develop branch when using the Cms Block grid in the admin section the delete option throws a fatal error.

Fatal error: Uncaught Error: Call to undefined method Magento\Cms\Model\ResourceModel\Block\Grid\Collection::_getAllIdsSelect()

dmanners
dmanners commented Feb 4, 2017
View reviewed changes
app/code/Magento/Cms/Model/ResourceModel/Block/Grid/Collection.php Outdated
* @return \Magento\Framework\DB\Select
* @throws \Magento\Framework\Exception\LocalizedException
*/
protected function _getAllIdsSelect($limit = null, $offset = null)
Copy link
Contributor Author

@dmanners dmanners Feb 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be in this class or the parent class here.

Copy link
Contributor Author

@dmanners dmanners Feb 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually looking at how pages work the problem could be that this class still has the function getAllIds rather than just using the parent method. Would also be nice to remove these methods if we can rely on the parent methods.

@dmanners
Copy link
Contributor Author

dmanners commented Feb 4, 2017

Again not sure if this is the best way to fix it. But since it is currently causing a fatal error and the removal stops the error I think it is good. Double checked with how the cms page grid collection works and I feel they are now working in the same way.

@okorshenko okorshenko self-assigned this Feb 4, 2017
@okorshenko okorshenko self-requested a review February 4, 2017 22:08
@dmanners dmanners force-pushed the fatal-error-on-block-delete branch from a51393f to 5565e05 Compare February 6, 2017 15:04
@okorshenko
Copy link
Contributor

okorshenko commented Feb 8, 2017

@dmanners we accepted this PR. But looks like due to rebase of this PR it is not get closed automatically. But anyway, thank you for contribution. We merged your initial code

@okorshenko okorshenko closed this Feb 8, 2017
@okorshenko okorshenko added this to the February 2017 milestone Feb 11, 2017
@dmanners dmanners deleted the fatal-error-on-block-delete branch July 26, 2017 12:00
@harshvardhanmalpani harshvardhanmalpani mentioned this pull request Sep 13, 2017
Closed
magento-team pushed a commit that referenced this pull request Dec 26, 2017
@miguelbalparda
MAGETWO-85930: Backport PR8418 - Fatal error on cms block grid delete #…
bbd03a4 
…12840

 - Merge Pull Request #12840 from duckchip/magento2:Backport-#8418
 - Merged commits:
   1. 8059598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@okorshenko okorshenko okorshenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@okorshenko okorshenko

Labels

Award: advanced bugfix Progress: accept

Projects

None yet

Milestone

February 2017

Development

Successfully merging this pull request may close these issues.

3 participants

@dmanners @okorshenko @vrann