Skip to content

[Backport] [Shipping] Adjusting the Contact Us Xpath #23019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eduard13
Copy link
Contributor

Original Pull Request

#22823

Description (*)

This PR adjusts the Xpath for the contact us on shipping details block, as result we should see the contact us link in the tracking information, if the shipping carrier won't be available.

Fixed Issues (if relevant)

  1. [Shipping] The contact us link isn't showing on order tracking page #22822: [Shipping] The contact us link isn't showing on order tracking page
  2. ...

Manual testing scenarios (*)

  1. Make sure you have enabled the Contact Us
    Stores / Configuration / Contacts [General] / Contact Us
  2. Create a new order
  3. Create a shipment for the order
    3.1 Add the Tracking Number by using USPS carrier
  4. Click on the Track Order link (from Order page)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Adjusting the Contact Us tracking info
@m2-assistant
Copy link

m2-assistant bot commented May 26, 2019

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Shipping Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 26, 2019
@eduard13 eduard13 requested a review from dmytro-ch May 26, 2019 21:07
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5169 has been created to process this Pull Request

@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone May 27, 2019
@eduard13 eduard13 deleted the 2.2-develop-PR-port-22823 branch July 27, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Shipping Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants