Skip to content

[Shipping] Adjusting the Contact Us Xpath #22823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

[Shipping] Adjusting the Contact Us Xpath #22823

merged 1 commit into from
May 23, 2019

Conversation

eduard13
Copy link
Contributor

Description (*)

This PR adjusts the Xpath for the contact us on shipping details block, as result we should see the contact us link in the tracking information, if the shipping carrier won't be available.

Fixed Issues (if relevant)

  1. [Shipping] The contact us link isn't showing on order tracking page #22822: [Shipping] The contact us link isn't showing on order tracking page
  2. ...

Manual testing scenarios (*)

  1. Make sure you have enabled the Contact Us
    Stores / Configuration / Contacts [General] / Contact Us
  2. Create a new order
  3. Create a shipment for the order
    3.1 Add the Tracking Number by using USPS carrier
  4. Click on the Track Order link (from Order page)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 10, 2019

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Shipping Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 10, 2019
@eduard13 eduard13 requested a review from dmytro-ch May 10, 2019 16:56
orlangur
orlangur requested changes May 11, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉

@ghost ghost assigned orlangur May 11, 2019
@eduard13 eduard13 force-pushed the 2.3-develop-shipping-contact-us branch 2 times, most recently from c797d67 to 284d4b8 Compare May 12, 2019 08:38
@eduard13
Copy link
Contributor Author

@orlangur thank you, the commits were squashed into a single commit.

@dmytro-ch dmytro-ch self-assigned this May 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5110 has been created to process this Pull Request

dmytro-ch
dmytro-ch requested changes May 13, 2019
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eduard13, could you please also fix the static test failures?

@eduard13
Adjusting the Contact Us tracking info
73869c3 
Adjusting the Contact Us tracking info
@eduard13 eduard13 force-pushed the 2.3-develop-shipping-contact-us branch from 284d4b8 to 73869c3 Compare May 13, 2019 10:41
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5110 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 14, 2019
@Nazar65 Nazar65 self-assigned this May 14, 2019
@soleksii
Copy link

✔️ QA Passed

Before:

before

After:

after

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5110 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request May 23, 2019
Closed
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 23, 2019
@sivaschenko
ENGCOM-5110: [Shipping] Adjusting the Contact Us Xpath magento#22823
6cb4d1b
@magento-engcom-team magento-engcom-team merged commit 73869c3 into magento:2.3-develop May 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 23, 2019
@dipti2jcommerce dipti2jcommerce mentioned this pull request May 24, 2019
Open
4 tasks
@eduard13 eduard13 mentioned this pull request May 26, 2019
Merged
4 tasks
@eduard13 eduard13 deleted the 2.3-develop-shipping-contact-us branch July 27, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@orlangur orlangur

@Nazar65 Nazar65

@dmytro-ch dmytro-ch

@soleksii soleksii

Labels
Award: bug fix Component: Shipping Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.3
Development

Successfully merging this pull request may close these issues.
6 participants
@eduard13 @magento-engcom-team @soleksii @orlangur @dmytro-ch @Nazar65