-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Improve swatch table overflow handling #21421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add overflow:auto to the three swatch tables to allow for scrolling if the amount of inputs exceeds the available space and increase the min width of inputs (150px) within the table for better usability. Intentionally left original input width (50px) as a fallback.
Hi @Cyanoxide. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @Cyanoxide. Thank you for your request. I'm working on Magento instance for you |
Hi @Cyanoxide, here is your new Magento instance. |
@magento-engcom-team give me test instance |
Hi @rogyar. Thank you for your request. I'm working on Magento instance for you |
Hi @rogyar, here is your new Magento instance. |
Hi @rogyar, thank you for the review. |
@Cyanoxide thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Hi @Cyanoxide, thank you for your contribution! |
Description (*)
Updates swatches.css to add overflow:auto to the three swatch tables (text, dropdown & visual) to allow for scrolling if the amount of inputs exceeds the available space and increase the min width of inputs (150px) within the table for better usability.
Intentionally left original input width (50px) as a fallback.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)