Skip to content

Improve swatch table overflow handling #21421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

Cyanoxide
Copy link
Contributor

@Cyanoxide Cyanoxide commented Feb 24, 2019

Description (*)

Updates swatches.css to add overflow:auto to the three swatch tables (text, dropdown & visual) to allow for scrolling if the amount of inputs exceeds the available space and increase the min width of inputs (150px) within the table for better usability.

Intentionally left original input width (50px) as a fallback.

Fixed Issues (if relevant)

  1. Fix Swatch Overflow issue #19932: Fix Swatch Overflow issue
  2. [Backport] Fix swatch overflow issue #19933: [backport] Fix Swatch Overflow issue

Manual testing scenarios (*)

  1. Add multiple store view and languages to your store (Our store has 19 but you should be able to reach replicate the issue with less)
  2. Open an attribute page within the Admin area to configure (Stores > Product > Any attribute).
  3. Table inputs at the bottom for languages should be too small to to use effectively
  4. If 3. isn't true add more store views, the more that are added the smaller the input fields get.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Add overflow:auto to the three swatch tables to allow for scrolling if the amount of inputs exceeds the available space and increase the min width of inputs (150px) within the table for better usability. 

Intentionally left original input width (50px) as a fallback.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 24, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Cyanoxide. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Cyanoxide
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Cyanoxide. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Cyanoxide, here is your new Magento instance.
Admin access: https://pr-21421.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@rogyar rogyar self-assigned this Feb 25, 2019
@rogyar
Copy link
Contributor

rogyar commented Feb 25, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-21421.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4372 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Cyanoxide thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit d78e69a into magento:2.3-develop Mar 1, 2019
@ghost
Copy link

ghost commented Mar 1, 2019

Hi @Cyanoxide, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants