-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] Fix swatch overflow issue #19933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When dealing with multiple store views with different languages the swatch input fields become too small to use and they move off the screen with no way to get to them. This fix adds a min-width to the input fields and handles swatch overflow with a scrollbar.
Hi @JamieRuroc. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@sidolov this version has also been updated, thank you. |
Hi @JamieRuroc , thank you for the update! We have the rule that all changes should be delivered to the 2.3-develop first, so, I added "on hold" label for this pull request right now and I'll remove it once #19932 will be merged. |
Hi @JamieRuroc , I am closing this PR because original was closed due to inactivity. |
Hi @JamieRuroc, thank you for your contribution! |
Description (*)
When dealing with multiple store views with different languages the swatch input fields become too small to use and they move off the screen with no way to get to them. This fix adds a min-width to the input fields and handles swatch overflow with a scrollbar.
Manual testing scenarios (*)
Backport for: #19932