Skip to content

Conversation

JamieRuroc
Copy link

@JamieRuroc JamieRuroc commented Dec 21, 2018

Description (*)

When dealing with multiple store views with different languages the swatch input fields become too small to use and they move off the screen with no way to get to them. This fix adds a min-width to the input fields and handles swatch overflow with a scrollbar.

Manual testing scenarios (*)

  1. Add multiple store views and languages to your store.
  2. Open an attribute page within the Backend (Stores > Product > "Attribute").
  3. Add more store views / languages until overflow happens.

Backport for: #19932

When dealing with multiple store views with different languages the swatch input fields become too small to use and they move off the screen with no way to get to them. This fix adds a min-width to the input fields and handles swatch overflow with a scrollbar.
@magento-engcom-team
Copy link
Contributor

Hi @JamieRuroc. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 21, 2018

CLA assistant check
All committers have signed the CLA.

@sidolov sidolov changed the title Fix swatch overflow issue [Backport] Fix swatch overflow issue Dec 21, 2018
@JamieRuroc
Copy link
Author

@sidolov this version has also been updated, thank you.

@sidolov
Copy link
Contributor

sidolov commented Jan 3, 2019

Hi @JamieRuroc , thank you for the update! We have the rule that all changes should be delivered to the 2.3-develop first, so, I added "on hold" label for this pull request right now and I'll remove it once #19932 will be merged.
Thank you!

@sidolov
Copy link
Contributor

sidolov commented Feb 7, 2019

Hi @JamieRuroc , I am closing this PR because original was closed due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Feb 7, 2019
@ghost
Copy link

ghost commented Feb 7, 2019

Hi @JamieRuroc, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants