Skip to content

Conversation

SyntaxKay
Copy link
Contributor

Original Pull Request

#19904

Description (*)

Magento 2.3-Develop
Store View label and Dropdown misaligned

Fixed Issues (if relevant)

1Store View label and Dropdown misaligned

Expected result (*)

  1. http://prntscr.com/lxgjmd

Actual result (*)

  1. http://prntscr.com/lxgja4

Manual testing scenarios (*)

1.N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3893 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 23, 2019

Hi @speedy008, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit c94cfbe into magento:2.2-develop Jan 23, 2019
magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants