Skip to content

Conversation

SyntaxKay
Copy link
Contributor

@SyntaxKay SyntaxKay commented Dec 20, 2018

Description (*)

Magento 2.3-Develop
Store View label and Dropdown misaligned

Fixed Issues (if relevant)

1Store View label and Dropdown misaligned

Expected result (*)

  1. http://prntscr.com/lxgjmd

Actual result (*)

  1. http://prntscr.com/lxgja4

Manual testing scenarios (*)

1.N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio
Copy link
Member

osrecio commented Dec 20, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @osrecio. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @osrecio, here is your new Magento instance.
Admin access: https://pr-19904.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@osrecio osrecio changed the title [Forwordport]Fix issue 19902 - Store View label and Dropdown misaligned [Forwardport]Fix issue 19902 - Store View label and Dropdown misaligned Dec 20, 2018
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @speedy008 .

I checked your PR in Vanilla env and PR env and it works.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @osrecio, thank you for the review.
ENGCOM-3726 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants