[Backport] Remove dead code #18431
Closed
[Backport] Remove dead code #18431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
\Magento\Cms\Model\Page::load() returns $this thus the if condition will never evaluate as false. And since there is an id check afterwards anyways we should be save.
magento-engcom-team
added
Partner: Experius
partners-contribution
Contributor
|
Hi @lewisvoncken. Thank you for your contribution. Please, consider fixing failing unit tests. Thank you |
Contributor
|
Hi @lewisvoncken , I am closing this PR now due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17401
\Magento\Cms\Model\Page::load() returns $this thus the if condition will never evaluate as false. And since there is an id check afterwards anyways we should be save. Basically applies #17400 in 2.3 develop.
Contribution checklist