Skip to content

Conversation

@shochdoerfer
Copy link
Member

\Magento\Cms\Model\Page::load() returns $this thus the if condition will never evaluate as false. And since there is an id check afterwards anyways we should be save.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

\Magento\Cms\Model\Page::load() returns $this thus the
if condition will never evaluate as false. And since
there is an id check afterwards anyways we should be
save.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 7, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @shochdoerfer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

Hi @shochdoerfer , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.2 release line. All code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Aug 7, 2018
@shochdoerfer shochdoerfer mentioned this pull request Aug 7, 2018
4 tasks
@lewisvoncken lewisvoncken mentioned this pull request Oct 6, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants