Skip to content

[Forwardport] CSS load order incorrect using default_head_blocks.xml #1821 #17829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2018
Merged

[Forwardport] CSS load order incorrect using default_head_blocks.xml #1821 #17829

merged 2 commits into from
Sep 11, 2018

Conversation

@nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Aug 28, 2018 •
edited by sidolov
Loading

Original Pull Request

#14290

Added new attribute 'order' for set loading order .
Those attribute resolve issue about render files for some order.

Fixed Issues (if relevant)

  1. CSS load order incorrect using default_head_blocks.xml #1821: CSS load order incorrect using default_head_blocks.xml CSS load order incorrect using default_head_blocks.xml #1821

@SerhiyDmytruk @nmalevanec
Fix bug #1821
d3e24ed 
Added new attribute 'order' for set loading order .
Those attribute resolve issue about render files for some order.
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 28, 2018

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@osrecio osrecio self-assigned this Aug 28, 2018
@osrecio osrecio self-requested a review August 28, 2018 10:17
osrecio
osrecio approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nmalevanec for your PR. We will process your PR ASAP.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 28, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 28, 2018

Hi @osrecio, thank you for the review.
ENGCOM-2891 has been created to process this Pull Request

@VladimirZaets VladimirZaets self-assigned this Aug 30, 2018
@ishakhsuvarov ishakhsuvarov mentioned this pull request Sep 11, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit fe6c96f into magento:2.3-develop Sep 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 11, 2018
ENGCOM-2891: [Forwardport] CSS load order incorrect using default_hea…
941fa8c 
…d_blocks.xml #1821 #17829
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 11, 2018

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osrecio osrecio osrecio approved these changes

+1 more reviewer

@williankeller williankeller williankeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@osrecio osrecio

@VladimirZaets VladimirZaets

Labels

Component: Framework/View Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nmalevanec @magento-engcom-team @osrecio @williankeller @VladimirZaets @SerhiyDmytruk