Fix static tests.

Author: nmalevanec

lib/internal/Magento/Framework/View/Page/Config/Reader/Head.php

@@ -7,6 +7,7 @@
 
 use Magento\Framework\View\Layout;
 use Magento\Framework\View\Page\Config as PageConfig;
+use Magento\Framework\View\Page\Config\Structure;
 
 /**
  * Head structure reader is intended for collecting assets, title and metadata
@@ -80,40 +81,10 @@ public function interpret(
         }
 
         ksort($orderedNodes);
-        foreach ($orderedNodes as $nodes ) {
+        foreach ($orderedNodes as $nodes) {
             /** @var \Magento\Framework\View\Layout\Element $node */
             foreach ($nodes as $node) {
-                switch ($node->getName()) {
-                    case self::HEAD_CSS:
-                    case self::HEAD_SCRIPT:
-                    case self::HEAD_LINK:
-                        $this->addContentTypeByNodeName($node);
-                        $pageConfigStructure->addAssets($node->getAttribute('src'), $this->getAttributes($node));
-                        break;
-
-                    case self::HEAD_REMOVE:
-                        $pageConfigStructure->removeAssets($node->getAttribute('src'));
-                        break;
-
-                    case self::HEAD_TITLE:
-                        $pageConfigStructure->setTitle(new \Magento\Framework\Phrase($node));
-                        break;
-
-                    case self::HEAD_META:
-                        $this->setMetadata($pageConfigStructure, $node);
-                        break;
-
-                    case self::HEAD_ATTRIBUTE:
-                        $pageConfigStructure->setElementAttribute(
-                            PageConfig::ELEMENT_TYPE_HEAD,
-                            $node->getAttribute('name'),
-                            $node->getAttribute('value')
-                        );
-                        break;
-
-                    default:
-                        break;
-                }
+                $this->processNode($node, $pageConfigStructure);
             }
         }
         return $this;
@@ -151,4 +122,46 @@ private function setMetadata($pageConfigStructure, $node)
 
         $pageConfigStructure->setMetadata($metadataName, $node->getAttribute('content'));
     }
+
+    /**
+     * Process given node based on it's name.
+     *
+     * @param Layout\Element $node
+     * @param Structure $pageConfigStructure
+     * @return void
+     */
+    private function processNode(Layout\Element $node, Structure $pageConfigStructure)
+    {
+        switch ($node->getName()) {
+            case self::HEAD_CSS:
+            case self::HEAD_SCRIPT:
+            case self::HEAD_LINK:
+                $this->addContentTypeByNodeName($node);
+                $pageConfigStructure->addAssets($node->getAttribute('src'), $this->getAttributes($node));
+                break;
+
+            case self::HEAD_REMOVE:
+                $pageConfigStructure->removeAssets($node->getAttribute('src'));
+                break;
+
+            case self::HEAD_TITLE:
+                $pageConfigStructure->setTitle(new \Magento\Framework\Phrase($node));
+                break;
+
+            case self::HEAD_META:
+                $this->setMetadata($pageConfigStructure, $node);
+                break;
+
+            case self::HEAD_ATTRIBUTE:
+                $pageConfigStructure->setElementAttribute(
+                    PageConfig::ELEMENT_TYPE_HEAD,
+                    $node->getAttribute('name'),
+                    $node->getAttribute('value')
+                );
+                break;
+
+            default:
+                break;
+        }
+    }
 }

lib/internal/Magento/Framework/View/Test/Unit/Page/Config/Generator/HeadTest.php

@@ -60,6 +60,9 @@ protected function setUp()
         );
     }
 
+    /**
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     */
     public function testProcess()
     {
         $generatorContextMock = $this->createMock(Context::class);
@@ -120,10 +123,10 @@ public function testProcess()
             ->with('file-url-css', 'css', ['attributes' => ['media' => 'all']]);
         $this->pageConfigMock->expects($this->at(1))
             ->method('addRemotePageAsset')
-            ->with('file-url-css-last','css', ['attributes' => ['media' => 'all' ] , 'order' => 30]);
+            ->with('file-url-css-last', 'css', ['attributes' => ['media' => 'all' ] , 'order' => 30]);
         $this->pageConfigMock->expects($this->at(2))
             ->method('addRemotePageAsset')
-            ->with('file-url-css-first','css', ['attributes' => ['media' => 'all'] , 'order' => 10]);
+            ->with('file-url-css-first', 'css', ['attributes' => ['media' => 'all'] , 'order' => 10]);
         $this->pageConfigMock->expects($this->at(3))
             ->method('addRemotePageAsset')
             ->with('file-url-link', Head::VIRTUAL_CONTENT_TYPE_LINK, ['attributes' => ['media' => 'all']]);

lib/internal/Magento/Framework/View/Test/Unit/Page/Config/Reader/HeadTest.php

@@ -84,12 +84,18 @@ public function testInterpret()
 
         $structureMock->expects($this->at(9))
             ->method('addAssets')
-            ->with('path/file-1.css', ['src' => 'path/file-1.css', 'media' => 'all', 'content_type' => 'css', 'order' => 10])
+            ->with(
+                'path/file-1.css',
+                ['src' => 'path/file-1.css', 'media' => 'all', 'content_type' => 'css', 'order' => 10]
+            )
             ->willReturnSelf();
 
         $structureMock->expects($this->at(10))
             ->method('addAssets')
-            ->with('path/file-2.css', ['src' => 'path/file-2.css', 'media' => 'all', 'content_type' => 'css', 'order' => 30])
+            ->with(
+                'path/file-2.css',
+                ['src' => 'path/file-2.css', 'media' => 'all', 'content_type' => 'css', 'order' => 30]
+            )
             ->willReturnSelf();
 
         $this->assertEquals($this->model, $this->model->interpret($readerContextMock, $element->children()[0]));