fix problem with setCartFixedRules #1768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: You redeclare setData to set imploded streets, but this method is used by Your discount model, for example $address->setCartFixedRules($cartRules); in result array of cart rules set like string and discount to whole cart don't work properly. How To Reproduce: You can reproduce this issue by giving discount to whole cart with more than 1 item in cart. Discount applied 1 time and after that you set array of cartRules to address, but in result you set string instead array and cartFixed rule was broken. screen shot - http://joxi.ru/vAWRbgGFMwzv2W?d=1 , http://joxi.ru/4Ak05d1hw3DVrq?d=1 Why this fix: Just redeclare setter of CartFixedRules and call parent setData to prevent imploding strings
|
This issue has aready been fixed in MAGETWO-42590 ticket on #1776 issue and will be delivered soon. But thank you for your efforts! |
|
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
|
This issue was fixed internally. Closing |
okorshenko
pushed a commit
that referenced
this pull request
Nov 27, 2017
Public Pull Requests #12397 Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store by @klakovskiy #12376 10058: Tablerate->getCsvFile() fails with non-default PHP upload_tmp_dir(2.3) by @RomaKis #12044 [Backport 2.3] Add swatch option: Prevent loosing data and default value if data is not populated via adminhtml by @gomencal Fixed Public Issues #12393 Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store #10058 Tablerate->getCsvFile() fails with non-default PHP upload_tmp_dir #9410 Impossible to add swatch options via Service Contracts if there is no existing swatch option for attribute #10707 Create attribute option via API for swatch attribute fails #10737 Can't import attribute option over API if option is 'visual swatch' #11032 Unable to add new options to swatch attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
You redeclare setData to set imploded streets, but this method is used by Your discount model, for example
$address->setCartFixedRules($cartRules);
in result array of cart rules set like string and discount to whole cart don't work properly.
How To Reproduce:
You can reproduce this issue by giving discount to whole cart with more than 1 item in cart.
Discount applied 1 time and after that you set array of cartRules to address, but in result you set string instead array and cartFixed rule was broken.
screen shot - http://joxi.ru/vAWRbgGFMwzv2W?d=1 , http://joxi.ru/4Ak05d1hw3DVrq?d=1
Why this fix:
Just redeclare setter of CartFixedRules and call parent setData to prevent imploding strings