Skip to content

Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store #12397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2017

Conversation

klakovsky
Copy link
Contributor

Description

Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" did not work correctly for multi-stores.

Fixed Issues (if relevant)

  1. Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store #12393: Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store

Manual testing scenarios

  1. Create two websites website1 (website_id = 1), website2 (website_id =2)
  2. Create new product SKU=product1 and check for "Product in Websites" only website2.
  3. Create new product attribute "attribute1" with "Catalog Input Type for Store Owner" equal "Fixed Product Tax".
  4. Assign attribute1 to default attribute set.
  5. Open product "product1" and find attribute1 and click the button "add" near "attribute1".

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 22, 2017

CLA assistant check
All committers have signed the CLA.

@mzeis mzeis self-assigned this Nov 22, 2017
@mzeis mzeis added this to the November 2017 milestone Nov 23, 2017
@mzeis mzeis added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Progress: accept labels Nov 23, 2017
@okorshenko okorshenko merged commit 7c5bdbe into magento:2.3-develop Nov 27, 2017
okorshenko pushed a commit that referenced this pull request Nov 27, 2017
@magento-engcom-team magento-engcom-team added Fixed in 2.3.x The issue has been fixed in 2.3 release line ready for backport labels Nov 27, 2017
@mzeis
Copy link
Contributor

mzeis commented Nov 28, 2017

@klakovskiy Thank you very much for your contribution! Your PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants