Skip to content

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Jan 6, 2018

Backport

This PR is a backport of the following PR: #12397

Description

Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" did not work correctly for multi-stores.

Fixed Issues

  1. Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store #12393: Attribute with "Catalog Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store

Manual testing scenarios

  1. Create two websites website1 (website_id = 1), website2 (website_id =2)
  2. Create new product SKU=product1 and check for "Product in Websites" only website2.
  3. Create new product attribute "attribute1" with "Catalog Input Type for Store Owner" equal "Fixed Product Tax".
  4. Assign attribute1 to default attribute set.
  5. Open product "product1" and find attribute1 and click the button "add" near "attribute1".

@magento-engcom-team magento-engcom-team added Fixed in 2.3.x The issue has been fixed in 2.3 release line ready for backport Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jan 6, 2018
@miguelbalparda miguelbalparda self-assigned this Jan 7, 2018
@miguelbalparda
Copy link
Contributor

Travis seems to be failing because of this @dverkade, can you check it?

@dverkade
Copy link
Member Author

dverkade commented Jan 7, 2018

Hi @miguelbalparda,

Strange, because as you can see from my commit I did not change the line which broke the build. I have fixed this issue and did a commit, Travis is now building correctly.

@miguelbalparda miguelbalparda added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 15, 2018
@magento-team magento-team merged commit 2502f84 into magento:2.1-develop Jan 24, 2018
magento-team pushed a commit that referenced this pull request Jan 24, 2018
…t Type for Store Owner" equal "Fixed Product Tax" for Multi-store #13020
magento-team pushed a commit that referenced this pull request Jan 24, 2018
…t Type for Store Owner" equal "Fixed Product Tax" for Multi-store #13020

 - fixed copyright
hostep added a commit to hostep/magento2 that referenced this pull request May 12, 2018
…log Input Type for Store Owner" equal "Fixed Product Tax" for Multi-store magento#13020"

This reverts commit 06fc4d7.
@dverkade dverkade deleted the 2.1-Attribute-with-Catalog-Input-Type-for-Store-Owner branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Insider: Cream community-insider-contribution Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants