Skip to content

[Forwardport] Refactor JS code and added JS component file #17630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 13, 2018
Merged

[Forwardport] Refactor JS code and added JS component file #17630

merged 7 commits into from
Sep 13, 2018

Conversation

@yogeshsuhagiya
Copy link
Member

@yogeshsuhagiya yogeshsuhagiya commented Aug 15, 2018 •
edited by sidolov
Loading

Original Pull Request

#17527

Description

Created a new JS component with the callback function.
Replaced <script/> tag with <script type="text/x-magento-init" />

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 15, 2018

Hi @yogeshks. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

sidolov
sidolov requested changes Aug 15, 2018
View reviewed changes
app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/form.phtml Outdated
});
<script type="text/x-magento-init">
{
'#edit_form': {
Copy link
Contributor

@sidolov sidolov Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes are not allowed in JSON configuration

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/form.phtml Outdated
{
'#edit_form': {
"Magento_Ui/catalog/product/edit/attribute": {
validationUrl: '<?= /* @escapeNotVerified */ $block->getValidationUrl() ?>'
Copy link
Contributor

@sidolov sidolov Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes are not allowed in JSON configuration

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/attribute.phtml Outdated
{
"#attributes-edit-form": {
"Magento_Ui/catalog/product/edit/attribute": {
validationUrl: '<?= /* @escapeNotVerified */ $block->getValidationUrl() ?>'
Copy link
Contributor

@sidolov sidolov Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes are not allowed in JSON configuration

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/form.phtml Outdated
<script type="text/x-magento-init">
{
'#edit_form': {
"Magento_Ui/catalog/product/edit/attribute": {
Copy link
Contributor

@sidolov sidolov Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File catalog/product/edit/attribute.js located in Magento_Catalog module instead of Magento_Ui

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/edit/action/attribute.phtml Outdated
<script type="text/x-magento-init">
{
"#attributes-edit-form": {
"Magento_Ui/catalog/product/edit/attribute": {
Copy link
Contributor

@sidolov sidolov Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File catalog/product/edit/attribute.js located in Magento_Catalog module instead of Magento_Ui

@yogeshks
Merge pull request #6 from Yogeshks/2.3-develop-PR-port-17575
9dc9e98 
[Forwardport] Translated validation error messages
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Aug 15, 2018 •
edited
Loading

@yogeshks just add following commit: 01ed836

@VladimirZaets VladimirZaets self-assigned this Aug 19, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 30, 2018

Hi @yogeshks , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 30, 2018
@ishakhsuvarov ishakhsuvarov reopened this Sep 12, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Sep 12, 2018
@magento-engcom-team magento-engcom-team merged commit 0ee1519 into magento:2.3-develop Sep 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 13, 2018
@ishakhsuvarov
ENGCOM-2960: [Forwardport] Refactor JS code and added JS component file
82b14a0 
#17630
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 13, 2018

Hi @yogeshks. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov requested changes

Assignees

@ishakhsuvarov ishakhsuvarov

@VladimirZaets VladimirZaets

Labels

Area: Frontend Component: Catalog Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

7 participants

@yogeshsuhagiya @magento-engcom-team @ihor-sviziev @sidolov @ishakhsuvarov @VladimirZaets @yogeshks