-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Refactor JS code and added JS component file #17527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JS code and added JS component file #17527
Conversation
|
Hi @yogeshks. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
|
||
| return function (config, element) { | ||
|
|
||
| jQuery(element).mage('form').mage('validation', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yogeshks. Thanks for the collaboration. Please use $ alias to jQuery instead of jQuery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @VladimirZaets , sure I'll do.
|
@yogeshks Thanks |
|
Hi @VladimirZaets, thank you for the review. |
|
Hi @yogeshks. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Created a new JS component with the callback function.
Replaced
<script/>tag with<script type="text/x-magento-init" />Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist