Skip to content

fix: fix Less linter warnings in adminhtml #17343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Aug 9, 2018
Merged

fix: fix Less linter warnings in adminhtml #17343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/design/adminhtml/Magento/backend/Magento_Analytics/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@
}

.advanced-reports-subscription-close {
display: inline-block;
vertical-align: top;
display: block;
Copy link
Contributor

@VladimirZaets VladimirZaets Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that we can change display inline-block to block? It can break UI.

Copy link
Contributor Author

@DanielRuf DanielRuf Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to float it is always handled as block.

See https://codepen.io/DanielRuf/pen/bjxgwm?editors=1100

Copy link
Contributor Author

@DanielRuf DanielRuf Aug 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/CSS/float

As float implies the use of the block layout, it modifies the computed value of the display values, in some cases:

specified computed
inline block
inline-block block
inline-table table
table-row block
table-row-group block
table-column block
table-column-group block
table-cell block
table-caption block
table-header-group block
table-footer-group block
flex flex, but float has no effect on such elements
inline-flex inline-flex, but float has no effect on such elements
other unchanged

float: right;
}

Expand Down
3 changes: 1 addition & 2 deletions app/design/adminhtml/Magento/backend/Magento_Backend/web/css/source/_module-old.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
.search-global-field .mage-suggest {
position: static;
display: block;
vertical-align: baseline;
width: auto;
background-color: transparent;
border: none;
Expand Down Expand Up @@ -177,7 +176,7 @@
}

&:before {
display: inline-block;
display: block;
float: right;
margin-left: 4px;
font-size: 13px;
Expand Down
3 changes: 2 additions & 1 deletion ...backend/Magento_ConfigurableProduct/web/css/source/module/components/_currency-addon.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
width: 100%;

.admin__control-text {
appearence: none;
-webkit-appearance: none;
appearance: none;
-webkit-flex-grow: 1;
flex-grow: 1;
-ms-flex-order: 1;
Expand Down
2 changes: 1 addition & 1 deletion ...Magento/backend/Magento_ConfigurableProduct/web/css/source/module/steps/_bulk-images.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@

.admin__field-control {
float: right;
display: inline-block;
display: block;
}
}
}
3 changes: 1 addition & 2 deletions app/design/adminhtml/Magento/backend/Magento_ReleaseNotification/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,7 @@
}

.release-notification-button-next, .release-notification-button-back {
display: inline-block;
vertical-align: top;
display: block;
float: right;
position: absolute;
bottom: 4rem;
Expand Down
4 changes: 2 additions & 2 deletions app/design/adminhtml/Magento/backend/Magento_Ui/web/css/source/_module-old.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,14 @@
.lib-clearfix();

[data-part=left] {
display: inline-block;
display: block;
width: 45%;
float: left;
text-align: left;
}

[data-part=right] {
display: inline-block;
display: block;
width: 45%;
text-align: right;
float: right;
Expand Down
2 changes: 1 addition & 1 deletion app/design/adminhtml/Magento/backend/Magento_VisualMerchandiser/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@

a {
color: @color-gray85;
display: inline-block;
display: block;
float: left;
text-decoration: none;
}
Expand Down
4 changes: 4 additions & 0 deletions app/design/adminhtml/Magento/backend/web/css/source/_reset.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ html {
// Prevent iOS text size adjust after orientation change, without disabling user zoom.
-ms-text-size-adjust: 100%;
-webkit-text-size-adjust: 100%;
text-size-adjust: 100%;
box-sizing: border-box;
}

Expand Down Expand Up @@ -234,6 +235,7 @@ html input[type='button'],
input[type='reset'],
input[type='submit'] {
-webkit-appearance: button;
appearance: button;
cursor: pointer;
}

Expand Down Expand Up @@ -275,6 +277,7 @@ input[type='number'] {
// Address 'appearance' set to 'searchfield' in Safari and Chrome.
input[type='search'] {
-webkit-appearance: textfield;
appearance: textfield;
}

// Remove inner padding and search cancel button in Safari and Chrome on OS X.
Expand All @@ -283,6 +286,7 @@ input[type='search'] {
&::-webkit-search-cancel-button,
&::-webkit-search-decoration {
-webkit-appearance: none;
appearance: none;
}
}

Expand Down
1 change: 0 additions & 1 deletion app/design/adminhtml/Magento/backend/web/css/source/actions/_actions-dropdown.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@
border: 0;
display: inline;
margin: 0;
width: 6rem;

body._keyfocus &:focus {
box-shadow: none;
Expand Down
1 change: 0 additions & 1 deletion app/design/adminhtml/Magento/backend/web/css/source/actions/_actions-switcher.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@
display: block;
height: @actions-switcher__height;
transition: background @actions-switcher-speed ease-in 0s;
vertical-align: middle;
width: @actions-switcher__width;
z-index: 0;
}
Expand Down
1 change: 1 addition & 0 deletions app/design/adminhtml/Magento/backend/web/css/source/components/_file-insertion.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

input {
-moz-transform: none;
transform: none;
border: none;
opacity: 1;
position: static;
Expand Down
1 change: 1 addition & 0 deletions app/design/adminhtml/Magento/backend/web/css/source/components/_media-gallery.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@
.image-panel-preview {
-ms-flex: 1;
-webkit-box-flex: 1;
box-flex: 1;
-webkit-flex: 1;
flex: 1;
}
Expand Down
1 change: 1 addition & 0 deletions app/design/adminhtml/Magento/backend/web/css/source/components/_popups.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@

input {
-moz-transform: none;
transform: none;
border: none;
opacity: 1;
position: static;
Expand Down
1 change: 1 addition & 0 deletions app/design/adminhtml/Magento/backend/web/css/source/forms/_temp.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,7 @@ label.mage-error {

.action-select-multiselect {
-webkit-appearance: menulist-button;
appearance: menulist-button;
height: 38px;
left: -1rem;
min-width: 0;
Expand Down
2 changes: 1 addition & 1 deletion app/design/adminhtml/Magento/backend/web/css/styles-old.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@
.nested .choice .label,
.nested .choice .control {
float: none;
width: auto;
position: static;
left: auto;
text-align: left;
Expand Down Expand Up @@ -1215,6 +1214,7 @@
-webkit-user-select: none; // use in 41 Chrome
-moz-user-select: none; // use in 36 Firefox
-ms-user-select: none; // use in 11 IE
user-select: none;
min-height: 39px;
}

Expand Down
1 change: 0 additions & 1 deletion app/design/adminhtml/Magento/backend/web/mui/styles/_table.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,6 @@ td.col-type {

.import {
display: block;
vertical-align: top;
}

.action-reset {
Expand Down