-
Notifications
You must be signed in to change notification settings - Fork 9.4k
fix: fix Less linter warnings in adminhtml #17343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @DanielRuf. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
| .advanced-reports-subscription-close { | ||
| display: inline-block; | ||
| vertical-align: top; | ||
| display: block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that we can change display inline-block to block? It can break UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to float it is always handled as block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://developer.mozilla.org/en-US/docs/Web/CSS/float
As float implies the use of the block layout, it modifies the computed value of the display values, in some cases:
| specified | computed |
|---|---|
| inline | block |
| inline-block | block |
| inline-table | table |
| table-row | block |
| table-row-group | block |
| table-column | block |
| table-column-group | block |
| table-cell | block |
| table-caption | block |
| table-header-group | block |
| table-footer-group | block |
| flex | flex, but float has no effect on such elements |
| inline-flex | inline-flex, but float has no effect on such elements |
| other | unchanged |
|
@magento-engcom-team give me test instance |
|
Hi @DanielRuf. Thank you for your request. I'm working on Magento instance for you |
|
Hi @DanielRuf, here is your new Magento instance. |
|
@DanielRuf ok, thanks |
|
Hi @DanielRuf. Thank you for your contribution. |
Description
This fixes a few findings of the linter in VisualStudio Code.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist