Skip to content

Conversation

@navarr
Copy link
Contributor

@navarr navarr commented Aug 2, 2018

Description

This is a forwardport of #17127

By returning the storage.post promise, third party modules can perform
additional actions by adding .done/.fail or .always tasks to the request
promise by creating a Javascript mixin for the totals processor.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

navarr and others added 5 commits August 2, 2018 13:04
by returning the storage.post promise, third party modules can perform
additional actions by adding .done/.fail or .always tasks to the request
promise by creating a Javascript mixin for the totals processor.
@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@navarr navarr deleted the 2.3-develop-PR-port-17127 branch December 12, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants