Skip to content

[Forwardport] Allow 3rd party modules to perform actions after totals calculation #17314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[Forwardport] Allow 3rd party modules to perform actions after totals calculation #17314

wants to merge 5 commits into from

Conversation

@mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Aug 1, 2018

Original Pull Request

#17127
By returning the storage.post promise, third party modules can perform
additional actions by adding .done/.fail or .always tasks to the request
promise by creating a Javascript mixin for the totals processor.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

navarr and others added 5 commits August 1, 2018 18:16
@navarr @mage2pratik
Allow 3rd party modules to perform actions after totals calculation
cd4c5b8 
by returning the storage.post promise, third party modules can perform
additional actions by adding .done/.fail or .always tasks to the request
promise by creating a Javascript mixin for the totals processor.
@navarr @mage2pratik
Update test to expect a deferral instead of undefined
c1deae5
@navarr @mage2pratik
Move new variables to top of scope to fall in line with convention
7e32b26
@mage2pratik
Fixed code style issues
c55c625
@navarr @mage2pratik
Fix styling issues
c4efcba
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 1, 2018

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Aug 2, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 2, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 2, 2018

Hi @orlangur, thank you for the review.
ENGCOM-2631 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Aug 2, 2018

Hi @mage2pratik , I'm closing this PR as a duplicate. Author of original PR created his own port: #17328

@sidolov sidolov closed this Aug 2, 2018
@mage2pratik mage2pratik deleted the 2.3-develop-PR-port-17127 branch August 10, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels

Area: Frontend Component: Checkout Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mage2pratik @magento-engcom-team @sidolov @orlangur @navarr