Skip to content

Fixed a couple of typos #17293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Fixed a couple of typos #17293

merged 1 commit into from
Aug 1, 2018

Conversation

dverkade
Copy link
Member

Description

  • Changed typo "whith" to "with"
  • Fixed typo and missing word in test name

Fixed Issues

None

- Fixed typo and missing word in test name
@magento-engcom-team
Copy link
Contributor

Hi @dverkade. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@okorshenko
Copy link
Contributor

@magento-engcom-team give me 2.2.4 verification instance

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko. Thank you for your request. I'm working on Magento 2.2.4 verification instance for you

@okorshenko
Copy link
Contributor

@magento-engcom-team give me new test instance

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, here is your new Magento instance.
Admin access: https://pr-17293.engcom.dev.magento.com/admin
Login: admin Password: 123123q

@dverkade
Copy link
Member Author

@okorshenko please note that this PR is on the 2.3-develop branch and not on the 2.2-develop branch. So this should be tested with 2.3

@okorshenko
Copy link
Contributor

@magento-engcom-team give me 2.2.4 instance

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko. Thank you for your request. I'm working on Magento 2.2.4 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, here is your Magento instance.
Admin access: https://i-17293-2-2-4.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team magento-engcom-team merged commit c5499a3 into magento:2.3-develop Aug 1, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dverkade. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants