Skip to content

Fixed typo mistakes #17274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed typo mistakes #17274

wants to merge 1 commit into from

Conversation

jignesh-baldha
Copy link
Member

Description

I've fixed typo mistakes.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@jignesh-baldha
Copy link
Member Author

@magento-engcom-team Don't need the test instance, I've just fixed typo mistakes.

dverkade
dverkade suggested changes Jul 30, 2018
View reviewed changes
Copy link
Member

@dverkade dverkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please check my comments for this PR.

...tests/integration/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/Images/OnInsertTest.php
@@ -23,7 +23,7 @@ class OnInsertTest extends AbstractBackendController
* @magentoConfigFixture admin_store cms/wysiwyg/use_static_urls_in_catalog 1
* @return void
*/
public function testExecuteWhithStaticUrls()
public function testExecutewithStaticUrls()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camel case, so this should be: testExecuteWithStaticUrls

...tests/integration/testsuite/Magento/Cms/Controller/Adminhtml/Wysiwyg/Images/OnInsertTest.php
@@ -36,7 +36,7 @@ public function testExecuteWhithStaticUrls()
* @magentoConfigFixture admin_store cms/wysiwyg/use_static_urls_in_catalog 0
* @return void
*/
public function testExecuteWhithoutStaticUrls()
public function testExecutewithoutStaticUrls()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camel case, so this should be: testExecuteWithoutStaticUrls

@sidolov
Copy link
Contributor

sidolov commented Jul 31, 2018

Hi @jignesh-baldha , unfortunately, we can't accept such Pull Requests to 2.2 release line, all code cleanup like typos, spelling mistakes, etc should be delivered to 2.3 release line. For more information, please, refer to Magento Code Contributions Guide

@sidolov sidolov closed this Jul 31, 2018
@dverkade
Copy link
Member

I have created a PR for Magento 2.3 here: #17293

@jignesh-baldha jignesh-baldha deleted the jignesh-patch2 branch August 27, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dverkade dverkade dverkade requested changes

Assignees
No one assigned
Labels
Area: Frontend Component: Ui Release Line: 2.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jignesh-baldha @magento-engcom-team @sidolov @dverkade