[Backport] Add @api annotation to Filter Group & Sort Order #17248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
the
Component: Framework/Api
Contributor
|
@mage2pratik , unfortunately, we can't accept this pull request due to [Backward Compatibility](Remove commented code) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16252
Description
This PR adds the FilterGroup and SortOrder classes to the public API for the magento/framework component. They are the only pieces of SearchCriteriaInterface that are not identified with an
@apiannotation. This causes usages of them for searching repositories in modules to depend on the patch level of the framework. Once merged, modules may use them while depending on the major version of the framework.Contribution checklist