Skip to content

Conversation

@navarr
Copy link
Contributor

@navarr navarr commented Jun 19, 2018

Description

This PR adds the FilterGroup and SortOrder classes to the public API for the magento/framework component. They are the only pieces of SearchCriteriaInterface that are not identified with an @api annotation. This causes usages of them for searching repositories in modules to depend on the patch level of the framework. Once merged, modules may use them while depending on the major version of the framework.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 19, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added the Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog label Jun 19, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 26, 2018
@magento-engcom-team magento-engcom-team merged commit beb3b8f into magento:2.3-develop Jul 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants