Skip to content

Conversation

@tiagosampaio
Copy link
Member

@tiagosampaio tiagosampaio commented Jul 18, 2018

Original PR: #16921

Changes like:

  • Standard and code visibility;
  • Changed addError, addSuccess by addErrorMessage, addSuccessMessage.

Description

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jul 28, 2018

Hi @tiagosampaio,
Unfortunately due to mistake @VladimirZaets already merged forwardport to 2.3-develop from another author #17106, so this PR become not relevant. Sorry for that.
I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants