Skip to content

Slight Changes to Code #16921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2018
Merged

Slight Changes to Code #16921

merged 2 commits into from
Jul 23, 2018

Conversation

@tiagosampaio
Copy link
Member

@tiagosampaio tiagosampaio commented Jul 18, 2018 •
edited
Loading

Changes like:

  • Standard and code visibility;
  • Changed addError, addSuccess by addErrorMessage, addSuccessMessage.

Description

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 18, 2018

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@tiagosampaio tiagosampaio mentioned this pull request Jul 18, 2018
Closed
4 tasks
ihor-sviziev
ihor-sviziev requested changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at unit tests - they are failing. Please adjust them

app/code/Magento/Cms/Controller/Adminhtml/Block/InlineEdit.php Outdated
$this->jsonFactory = $jsonFactory;
}

Copy link
Contributor

@ihor-sviziev ihor-sviziev Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert change on this line

app/code/Magento/Cms/Controller/Adminhtml/Page/InlineEdit.php Outdated
$this->jsonFactory = $jsonFactory;
}

Copy link
Contributor

@ihor-sviziev ihor-sviziev Jul 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert change on this line

@ihor-sviziev ihor-sviziev self-assigned this Jul 19, 2018
@tiagosampaio
Copy link
Member Author

tiagosampaio commented Jul 19, 2018

@ihor-sviziev the fixes for tests were applied and the changes were made for the files you mentioned.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jul 20, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 20, 2018

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2437 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 3fb1ecf into magento:2.2-develop Jul 23, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 23, 2018
ENGCOM-2437: Slight Changes to Code #16921
92b6387
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jul 23, 2018

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mage2pratik mage2pratik mentioned this pull request Jul 24, 2018
Merged
4 tasks
@tiagosampaio tiagosampaio deleted the 2.2-develop-002 branch August 7, 2018 12:57
@tiagosampaio tiagosampaio restored the 2.2-develop-002 branch October 18, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

Labels

Component: Cms Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.6

Development

Successfully merging this pull request may close these issues.

3 participants

@tiagosampaio @magento-engcom-team @ihor-sviziev