-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forwardport] 15319 : misleading data-container in product list #16695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forwardport] 15319 : misleading data-container in product list #16695
Conversation
|
Hi @mageprince. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@mageprince please cherry-pick commit from #15350 instead of doing a new commit and force push to your current branch. |
|
@orlangur Can you please explain why we need cherry-pick for this PR ? |
|
@mageprince , cherry-pick is needed because we are trying to keep the original author in new commits during porting PRs across release lines. |
|
@sidolov Thanks for the information. I have just do cherry-pick of the main commit. |
|
@mageprince branch history is incorrect. You need to have something like |
This reverts commit e9893bd.
|
@mageprince revert is not what I was asking for. Are you going to rewrite branch history properly and make a force push? |
|
Hi @mageprince , I am closing this PR now due to inactivity. |
Description
Change static data-container class "product-grid" to $viewMode
Related issue
#15319
Contribution checklist
Original PR
#15350