Skip to content

Conversation

@mageprince
Copy link
Contributor

@mageprince mageprince commented Jul 10, 2018

Description

Change static data-container class "product-grid" to $viewMode

Related issue

#15319

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Original PR

#15350

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

@mageprince please cherry-pick commit from #15350 instead of doing a new commit and force push to your current branch.

@orlangur orlangur changed the title Remove static data-container class in product list [Forwardport] 15319 : misleading data-container in product list Jul 10, 2018
@mageprince
Copy link
Contributor Author

@orlangur Can you please explain why we need cherry-pick for this PR ?

@sidolov
Copy link
Contributor

sidolov commented Aug 2, 2018

@mageprince , cherry-pick is needed because we are trying to keep the original author in new commits during porting PRs across release lines.

@mageprince
Copy link
Contributor Author

@sidolov Thanks for the information. I have just do cherry-pick of the main commit.

@orlangur orlangur removed the request for review from magento-engcom-team August 2, 2018 12:11
@orlangur
Copy link
Contributor

orlangur commented Aug 2, 2018

@mageprince branch history is incorrect. You need to have something like sunilit42 authored and mageprince committed for all of the commits. Please rewrite history accordingly and force push into the same branch.

@orlangur
Copy link
Contributor

orlangur commented Aug 2, 2018

@mageprince revert is not what I was asking for. Are you going to rewrite branch history properly and make a force push?

@sidolov
Copy link
Contributor

sidolov commented Aug 16, 2018

Hi @mageprince , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants