Skip to content

Conversation

@sunilit42
Copy link
Contributor

@sunilit42 sunilit42 commented May 19, 2018

Issue :- #15319

Description

  • change data-container class name based on view mode

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018

CLA assistant check
All committers have signed the CLA.

@SubrataBauri
Copy link

@sunilit42 you have to sign the License CLA

@sunilit42
Copy link
Contributor Author

@sidolov

I did, please check it.

@sidolov
Copy link
Contributor

sidolov commented May 21, 2018

Hi @sunilit42 , looks like changes to Magento/Analytics/etc/adminhtml/system.xml was added by mistake, please, revert this file.

@sunilit42
Copy link
Contributor Author

@sidolov
sorry for that.

i did revert back. please check it.

@magento-engcom-team
Copy link
Contributor

Hi @sunilit42. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants