Skip to content

15319 : misleading data-container in product list #15350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2018
Merged

15319 : misleading data-container in product list #15350

merged 3 commits into from
May 22, 2018

Conversation

@sunilit42
Copy link
Contributor

@sunilit42 sunilit42 commented May 19, 2018 •
edited
Loading

Issue :- #15319

Description

  • change data-container class name based on view mode

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SubrataBauri
Copy link

@sunilit42 you have to sign the License CLA

@sunilit42
Copy link
Contributor Author

@sidolov

I did, please check it.

@sidolov
Copy link
Contributor

sidolov commented May 21, 2018

Hi @sunilit42 , looks like changes to Magento/Analytics/etc/adminhtml/system.xml was added by mistake, please, revert this file.

@sunilit42
Copy link
Contributor Author

@sidolov
sorry for that.

i did revert back. please check it.

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 21, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request May 22, 2018
Closed
magento-team pushed a commit that referenced this pull request May 22, 2018
@VladimirZaets
ENGCOM-1622: 15319 : misleading data-container in product list #15350
d870d06
@magento-engcom-team magento-engcom-team merged commit 03465eb into magento:2.2-develop May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sunilit42. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@viral-wagento viral-wagento mentioned this pull request Jun 5, 2018
Merged
@orlangur orlangur mentioned this pull request Jun 14, 2018
Closed
@orlangur orlangur mentioned this pull request Jul 10, 2018
Closed
4 tasks
@nmalevanec nmalevanec mentioned this pull request Aug 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sidolov sidolov

Labels

Event: dmcdindia Progress: accept Release Line: 2.2

Projects

None yet

Milestone

May 2018

Development

Successfully merging this pull request may close these issues.

6 participants

@sunilit42 @magento-cicd2 @SubrataBauri @sidolov @magento-engcom-team @vijay-wagento