Skip to content

[Backport] Fix duplicate element id issue. #16264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2018
Merged

[Backport] Fix duplicate element id issue. #16264

merged 1 commit into from
Jun 23, 2018

Conversation

@chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented Jun 20, 2018

Original Pull Request
#15585

Description

Fixed Issues (if relevant)

  1. Duplicated elements id in checkout page #13415: Duplicated elements id in checkout page

Manual testing scenarios

  1. Chrome didn't display error in console related to non unique ID

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: GiftMessage labels Jun 20, 2018
@chirag-wagento
Copy link
Contributor Author

chirag-wagento commented Jun 20, 2018

As per this tickets comment #16123 (comment) created new pull request.

@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 21, 2018
@sidolov sidolov mentioned this pull request Jun 23, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit c9e5239 into magento:2.1-develop Jun 23, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 23, 2018
ENGCOM-2080: [Backport] Fix duplicate element id issue. #16264
047d330
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jun 23, 2018

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

@Sathishkumar8731
Copy link

Sathishkumar8731 commented Jul 4, 2018

@chirag-wagento

Could you please share me the changes which you have done for the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@VladimirZaets VladimirZaets

Labels

Area: Frontend Component: GiftMessage Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1

Projects

None yet

Milestone

Release: 2.1.15

Development

Successfully merging this pull request may close these issues.

4 participants

@chirag-wagento @magento-engcom-team @Sathishkumar8731 @VladimirZaets