Skip to content

[Backport] Fix #13415 : Duplicated elements id #16123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

[Backport] Fix #13415 : Duplicated elements id #16123

wants to merge 28 commits into from

Conversation

@chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented Jun 14, 2018

Original Pull Request
#15585

Description

Fixed Issues (if relevant)

  1. Duplicated elements id in checkout page #13415: Duplicated elements id in checkout page

Manual testing scenarios

  1. Chrome didn't display error in console related to non unique ID

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

chirag-wagento and others added 28 commits June 4, 2018 10:34
@chirag-wagento
Product placeholder image resize issue #13636
acf52ec
@chirag-wagento
Merge pull request #1 from chirag-wagento/2.1-develop-PR-port-15758
e7fc759 
[Backport] Product placeholder image resize issue #13636
@chirag-wagento
Merge pull request #3 from chirag-wagento/2.1-develop-PR-port-15789
0b5167e 
[Backport] Removed unnecessary css.
@chirag-wagento
Merge pull request #5 from chirag-wagento/2.1-develop-PR-port-15790
682a932 
[Backport] Make necessary space.
@chirag-wagento
Removed unused class from forms less file.
3c88933
@chirag-wagento
Merge pull request #7 from chirag-wagento/2.1-develop-PR-port-15791
72d8d08 
[Backport] Removed unused class from forms less file.
@lewisvoncken @chirag-wagento
Added row_id to the flat action indexer so the value isn't set to 0 f…
c080b15 
…or new products when using index on save
@lewisvoncken @chirag-wagento
Moved the indexAll after the product save in the Indexer Product Flat…
ac0e159 
… RowTest
@chirag-wagento
Merge pull request #9 from chirag-wagento/2.1-develop-PR-port-15010
515dbae 
[Backport] [BUGFIX] Added row_id to the flat action indexer so the value isn't s…
@seruymt @chirag-wagento
fix tets fixture and mark return processor as @api
24cea81
@chirag-wagento
Merge pull request #12 from chirag-wagento/2.1-develop-PR-port-14842
a21c213 
[Backport] For MSI-377: fix test fixture and mark return processor as @api
@chirag-wagento
Merge pull request #15 from chirag-wagento/2.1-develop-PR-port-14805
10fd645 
[Backport] Fix for issue 911 found on MSI project - Cannot read property source_…
@chirag-wagento
Merge remote-tracking branch 'upstream/2.1-develop' into 2.1-develop
391eb00
@chirag-wagento
Merge pull request #20 from chirag-wagento/2.1-develop-PR-port-15558
29cd4e2 
[Backport] Fixes in catalog component blocks [2.3-develop]
@ankurvr @chirag-wagento
Wrong Last orders amount on dashboard #15660
fa35876 
Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660
@chirag-wagento
Merge pull request #24 from chirag-wagento/2.1-develop-PR-port-15661
a5990ec 
[Backport] Fixed Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies
@likemusic @chirag-wagento
small refactoring to better code readability
f34c978
@chirag-wagento
Merge pull request #28 from chirag-wagento/2.1-develop-PR-port-16010
a7fc075 
[Backport] Small refactoring to better code readability
@Karlasa @chirag-wagento
added new variables
324ee50
@Karlasa @chirag-wagento
added new primary button variables
41b4775
@chirag-wagento
Merge pull request #31 from chirag-wagento/2.1-develop-PR-port-16012
f530c43 
[Backport] Fix issue #15832
@Karlasa @chirag-wagento
checkout page cart icon color fix
c87e8af
@chirag-wagento
Merge pull request #33 from chirag-wagento/2.1-develop-PR-port-16002
a1a79b4 
[Backport] bugfix checkout page cart icon color
@chirag-wagento
Merge pull request #36 from chirag-wagento/2.1-develop-PR-port-15991
b5e4c23 
[Backport] fix for dropdown toggle icon in cart
@chirag-wagento
Merge remote-tracking branch 'upstream/2.1-develop' into 2.1-develop
7517bbc
@chirag-wagento
Merge branch '2.1-develop' of github.com:chirag-wagento/magento2 into…
28e922c 
… 2.1-develop
@chirag-wagento
Merge remote-tracking branch 'upstream/2.1-develop' into 2.1-develop
31aeccd
@chirag-wagento
Fix Duplicated elements id.
4c22007
@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 14, 2018
@osrecio osrecio self-assigned this Jun 14, 2018
@osrecio
Copy link
Member

osrecio commented Jun 14, 2018

Closing this PR. Check trace of Commits and create new PR with cherrypick commits

@osrecio osrecio closed this Jun 14, 2018
@chirag-wagento
Copy link
Contributor Author

chirag-wagento commented Jun 14, 2018

Hello @osrecio

Sorry not getting you can you please explain me in brief.

Thanks

This was referenced Jun 20, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@osrecio osrecio

Labels

Area: Design/Frontend Area: Frontend Area: Lib/Frontend Component: Backend Component: Catalog Component: GiftMessage Component: SalesInventory Component: Wishlist Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: reject

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@chirag-wagento @osrecio @magento-engcom-team @lewisvoncken @seruymt @ankurvr @likemusic @Karlasa