Skip to content

Conversation

@chirag-wagento
Copy link
Contributor

Original Pull Request

#15936
removed extraneous margin and compensated padding and set both to 0, which creates the same effect

Description

Change in the theme which gives the same effect, but removes the negative margin which was compensated with a padding.

Fixed Issues (if relevant)

  1. extraneous margins on product list and product list items #15308: extraneous margins on product list and product list items

Manual testing scenarios

  1. open list view of products on a page
  2. inspect the list .column.main .product-items and one product .products-list .product-item
  3. check if the negative margin and positive padding are replaced by 0 and if the styling is still correct

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

removed extraneous margin and compensated padding and set both to 0, which creates the same effect
@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jun 10, 2018
@chirag-wagento
Copy link
Contributor Author

Hello @sidolov

Any update in this PR?

Thanks

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1986 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants