-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Fixed in 2.1.xThe issue has been fixed in 2.1 release lineThe issue has been fixed in 2.1 release lineFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedRelease Line: 2.2
Description
Preconditions
- Magento 2.2.4
Steps to reproduce
- open list view of products on a page
- inspect the list
.column.main .product-itemsand one product.products-list .product-item
Expected result
- there should not be any extraneous styles
Actual result
- there are negative and positive margins which do nothing combined
The following code would remove it:
.products-list .product-item {
padding-left: 0;
}
.column.main .product-items {
margin-left: 0;
}In general I see no sense in these margins and paddings.
See
magento2/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_listings.less
Lines 167 to 177 in c0123f3
| .column.main { | |
| .product { | |
| &-items { | |
| margin-left: -@indent__base; | |
| } | |
| &-item { | |
| padding-left: @indent__base; | |
| } | |
| } | |
| } |
Metadata
Metadata
Assignees
Labels
Fixed in 2.1.xThe issue has been fixed in 2.1 release lineThe issue has been fixed in 2.1 release lineFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedRelease Line: 2.2