Skip to content

Conversation

@viral-wagento
Copy link
Contributor

Original Pull Request

#15621

Description

Browsing through the source code, we found occurences of the word "Caterory" in tests, which seemed as if it would be a typo. Please have a look - and just close it, if we are wrong. ;) Thank you!!!

Fixed Issues (if relevant)

  1. Typo in tests / setCateroryIds([]) #15590: tests / setCateroryIds
  2. ...

Manual testing scenarios

Browse to https://github.com/magento/magento2/search?q=setcateroryids&unscoped_q=setcateroryids

Expected result

  1. I would expect to see no function calls for "setCateroryIds"

Actual result

  1. I see several occurrences of "setCateroryIds":

screen shot 2018-05-30 at 2 13 39 pm

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@orlangur orlangur self-assigned this Jun 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-1841 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @viral-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants