Skip to content

Conversation

@neeta-wagento
Copy link
Contributor

Description

Browsing through the source code, we found occurences of the word "Caterory" in tests, which seemed as if it would be a typo. Please have a look - and just close it, if we are wrong. ;) Thank you!!!

Fixed Issues (if relevant)

  1. Typo in tests / setCateroryIds([]) #15590: tests / setCateroryIds
  2. ...

Manual testing scenarios

Browse to https://github.com/magento/magento2/search?q=setcateroryids&unscoped_q=setcateroryids

Expected result

  1. I would expect to see no function calls for "setCateroryIds"

Actual result

  1. I see several occurrences of "setCateroryIds":

screen shot 2018-05-30 at 2 13 39 pm

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 31, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jun 1, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept labels Jun 1, 2018
@magento-engcom-team magento-engcom-team merged commit 1d47b28 into magento:2.2-develop Jun 2, 2018
@magento-engcom-team
Copy link
Contributor

Hi @neeta-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants