Skip to content

Conversation

@dmytro-ch
Copy link
Contributor

Original PR: #15515

Description

The constructor in Magento\Webapi\Model\Soap\Fault.php assigns the $exception->getOriginator() to a dynamical property _soapCode instead of the existing _soapFaultCode. See on line 177

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.1 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels Jun 3, 2018
@dmytro-ch dmytro-ch requested a review from rogyar June 3, 2018 08:14
@magento-engcom-team magento-engcom-team added the Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" label Jun 3, 2018
@dmytro-ch dmytro-ch changed the title Fix dynamical assigned property as it wasn't assigned to an existing one [Backport] Fix dynamical assigned property as it wasn't assigned to an existing one Jun 3, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jun 3, 2018
@magento-engcom-team magento-engcom-team merged commit 7d703e2 into magento:2.1-develop Jun 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 4, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.1.15 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants