Skip to content

[fix] dynamical assigned property in webapi #15515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2018
Merged

[fix] dynamical assigned property in webapi #15515

merged 1 commit into from
May 27, 2018

Conversation

@mhauri
Copy link

@mhauri mhauri commented May 25, 2018 •
edited
Loading

Description

The constructor in Magento\Webapi\Model\Soap\Fault.php assigns the $exception->getOriginator() to a dynamical property _soapCode instead of the existing _soapFaultCode. See on line 177

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mzeis mzeis self-assigned this May 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 25, 2018
@magento-engcom-team magento-engcom-team added the Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" label May 25, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 25, 2018

Hi @mzeis, thank you for the review.
ENGCOM-1684 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit eead125 into magento:2.2-develop May 27, 2018
magento-engcom-team pushed a commit that referenced this pull request May 27, 2018
ENGCOM-1684: [fix] dynamical assigned property in webapi #15515
5b39538
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 27, 2018

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@mzeis mzeis mentioned this pull request May 30, 2018
Merged
4 tasks
@dmytro-ch dmytro-ch mentioned this pull request Jun 3, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mzeis mzeis mzeis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mzeis mzeis

Labels

bugfix Component: Webapi Use with concrete module component label E.g. "Component: Webapi" + "Catalog" Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mhauri @magento-engcom-team @mzeis