Skip to content

[fix] typo in method name _getCharg[e]ableOptionPrice #15276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2018
Merged

[fix] typo in method name _getCharg[e]ableOptionPrice #15276

merged 2 commits into from
May 20, 2018

Conversation

@mhauri
Copy link

@mhauri mhauri commented May 17, 2018 •
edited
Loading

Description

Method name \Magento\Catalog\Model\Product\Option\Type::_getChargableOptionPrice contained typo.

Renamed it to _getChargeableOptionPrice.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda miguelbalparda self-assigned this May 17, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 17, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 17, 2018

Hi @miguelbalparda, thank you for the review.
ENGCOM-1580 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 17, 2018

@mhauri thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@orlangur orlangur self-assigned this May 17, 2018
orlangur
orlangur requested changes May 17, 2018
View reviewed changes
app/code/Magento/Catalog/Model/Product/Option/Type/DefaultType.php
* @return float
*/
protected function _getChargableOptionPrice($price, $isPercent, $basePrice)
protected function _getChargeableOptionPrice($price, $isPercent, $basePrice)
Copy link
Contributor

@orlangur orlangur May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protected methods cannot be removed, please check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html#php:

Public and protected method removal
Mark the method with the @deprecated tag instead of removing it.

miguelbalparda
miguelbalparda requested changes May 17, 2018
View reviewed changes
Copy link
Contributor

@miguelbalparda miguelbalparda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protected methods cannot be removed, please check https://devdocs.magento.com/guides/v2.2/contributor-guide/backward-compatible-development/index.html

@mhauri
Copy link
Author

mhauri commented May 18, 2018 •
edited
Loading

@orlangur I've added the deprecated info in commit: 8ea661c

@magento-engcom-team magento-engcom-team merged commit 8ea661c into magento:2.2-develop May 20, 2018
magento-engcom-team pushed a commit that referenced this pull request May 20, 2018
ENGCOM-1580: [fix] typo in method name _getCharg[e]ableOptionPrice #1…
2bd2994 
…5276
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 20, 2018

Hi @mhauri. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

@osrecio osrecio mentioned this pull request May 29, 2018
Merged
4 tasks
@gelanivishal gelanivishal mentioned this pull request Jul 25, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur requested changes

@miguelbalparda miguelbalparda miguelbalparda requested changes

+1 more reviewer

@DanielRuf DanielRuf DanielRuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@orlangur orlangur

@miguelbalparda miguelbalparda

Labels

Progress: accept Release Line: 2.2

Projects

None yet

Milestone

May 2018

Development

Successfully merging this pull request may close these issues.

5 participants

@mhauri @magento-engcom-team @orlangur @DanielRuf @miguelbalparda