[Backport] [fix] typo in method name _getCharg[e]ableOptionPrice #17118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishakhsuvarov
requested changes
Jul 25, 2018
| * @param boolean $isPercent Price type - percent or fixed | ||
| * @param float $basePrice For percent price type | ||
| * @return float | ||
| * @deprecated 102.0.4 typo in method name |
Contributor
There was a problem hiding this comment.
This is incorrect module version for 2.1 release line
| * @param float $basePrice For percent price type | ||
| * @return float | ||
| */ | ||
| protected function _getChargeableOptionPrice($price, $isPercent, $basePrice) |
Contributor
There was a problem hiding this comment.
It would make sense to remove underscore, if renaming method anyway.
Contributor
Author
|
@ishakhsuvarov I have performed requested changes. |
sidolov
requested changes
Jul 25, 2018
| $option = $this->getOption(); | ||
|
|
||
| return $this->_getChargableOptionPrice($option->getPrice(), $option->getPriceType() == 'percent', $basePrice); | ||
| return $this->_getChargeableOptionPrice($option->getPrice(), $option->getPriceType() == 'percent', $basePrice); |
Contributor
There was a problem hiding this comment.
Method _getChargeableOptionPrice does not exist
| * @param boolean $isPercent Price type - percent or fixed | ||
| * @param float $basePrice For percent price type | ||
| * @return float | ||
| * @see _getChargeableOptionPrice |
Contributor
There was a problem hiding this comment.
Method _getChargeableOptionPrice does not exist
| $_result = $option->getValueById($value); | ||
| if ($_result) { | ||
| $result += $this->_getChargableOptionPrice( | ||
| $result += $this->_getChargeableOptionPrice( |
Contributor
There was a problem hiding this comment.
Method _getChargeableOptionPrice does not exist
| $_result = $option->getValueById($optionValue); | ||
| if ($_result) { | ||
| $result = $this->_getChargableOptionPrice( | ||
| $result = $this->_getChargeableOptionPrice( |
Contributor
There was a problem hiding this comment.
Method _getChargeableOptionPrice does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15276
Description
Method name
\Magento\Catalog\Model\Product\Option\Type::_getChargableOptionPricecontained typo.Renamed it to
_getChargeableOptionPrice.Contribution checklist