[Backport] Pass parameter for export button url #14903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
| * @param ContextInterface $context | ||
| * @return array | ||
| */ | ||
| protected function getAdditionalParams($config, $context) |
There was a problem hiding this comment.
Hi @rogyar , due to Magento backward compatibility we can't introduce new public and protected methods. Please change it to private.
Backward compatible development
|
@VladimirZaets my fault. Fixed the scope. Thank you |
|
Hi @rogyar , thanks for the fast update. But, I found the second problem, Magento 2.1 doesn't support attribute "active", and as I see, this attribute not needed for this case. Can you please remove it? |
|
@VladimirZaets sure, I've removed the attribute. Thank you for spotting |
|
Hi @rogyar. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #13208
Description
Pass parameter to export button url, configure button in invoice, shipment and creditmemo xml file
Fixed Issues (if relevant)
Manual testing scenarios