Skip to content

#12714 - pass parameter for export button url #13208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2018
Merged

#12714 - pass parameter for export button url #13208

merged 1 commit into from
Jan 18, 2018

Conversation

@sanjay-wagento
Copy link
Contributor

@sanjay-wagento sanjay-wagento commented Jan 16, 2018

Extra records are in exported CSV file for order

Description

Pass parameter to export button url, configure button in invoice, shipment and creditmemo xml file

Fixed Issues (if relevant)

  1. Extra records are in exported CSV file for order #12714: Extra records are in exported CSV file for order

Manual testing scenarios

  1. Log in to Admin
  2. Go to Sales > Orders
  3. Open one of the orders from preconditions
  4. Go to Invoices tab
  5. Click Export and select CSV
  6. Open exported CSV file

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added bugfix mageconf Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Component: Sales labels Jan 16, 2018
@rogyar rogyar self-assigned this Jan 18, 2018
@rogyar rogyar self-requested a review January 18, 2018 07:06
@rogyar rogyar added this to the January 2018 milestone Jan 18, 2018
@magento-team magento-team mentioned this pull request Jan 18, 2018
Closed
@magento-team magento-team merged commit f7baf29 into magento:2.2-develop Jan 18, 2018
magento-team pushed a commit that referenced this pull request Jan 18, 2018
@ishakhsuvarov
MAGETWO-86845: #12714 - pass parameter for export button url #13208
6a48b85
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 18, 2018
@rogyar rogyar mentioned this pull request Apr 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogyar rogyar rogyar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

Labels

bugfix Component: Sales Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@sanjay-wagento @rogyar @magento-team @magento-engcom-team