Skip to content

Added language translation, make proper sentence and removed unused delete html container #14308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Added language translation, make proper sentence and removed unused delete html container #14308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a467597
Added translation for delete confirm popup box
yogeshsuhagiya Mar 24, 2018
796ad09
Make proper sentence for confirm box
yogeshsuhagiya Mar 24, 2018
80383db
Removed unused delete html container
yogeshsuhagiya Mar 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Integration/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Reset,Reset
"A token with consumer ID 0 does not exist","A token with consumer ID 0 does not exist"
"The integration you selected asks you to approve access to the following:","The integration you selected asks you to approve access to the following:"
"No permissions requested","No permissions requested"
"Are you sure ?","Are you sure ?"
"Are you sure?","Are you sure?"
"Are you sure you want to delete this integration? You can't undo this action.","Are you sure you want to delete this integration? You can't undo this action."
"Please setup or sign in into your 3rd party account to complete setup of this integration.","Please setup or sign in into your 3rd party account to complete setup of this integration."
"Available APIs","Available APIs"
Expand Down
16 changes: 3 additions & 13 deletions app/code/Magento/Integration/view/adminhtml/templates/integration/popup_container.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
$('div#integrationGrid').on('click', 'button#delete', function (e) {

new Confirm({
title: 'Are you sure?',
content: "Are you sure you want to delete this integration? You can't undo this action.",
title: '<?= /* @escapeNotVerified */ __('Are you sure?') ?>',
content: "<?= /* @escapeNotVerified */ __("Are you sure you want to delete this integration? You can't undo this action.") ?>",
actions: {
confirm: function () {
window.location.href = $(e.target).data('url');
Expand All @@ -47,14 +47,4 @@
});
</script>

<div id="integration-popup-container" style="display: none;"></div>
<div id="integration-delete-container"
class="messages"
style="display: none;"
title="<?= /* @escapeNotVerified */ __('Are you sure ?') ?>">
<div class="message message-notice notice">
<div>
<?= /* @escapeNotVerified */ __("Are you sure you want to delete this integration? You can't undo this action.") ?>
</div>
</div>
</div>
<div id="integration-popup-container" style="display: none;"></div>