Added language translation, make proper sentence and removed unused delete html container #14308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 27, 2018
…oved unused delete html container #14308
|
@yogeshks : Well done, You saved my day 🎉 👏 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added language translation for two message appears inside modal popup on click delete icon of integration. (Goto: SYSTEM > Extensions > Integrations)
Delete confirm box appears on triggering click event of delete icon at integration grid through Confirm (Magento_Ui/js/modal/confirm) javascript class.
Delete confirm box appears through Confirm class so there is no use of #integration-delete-container HTML block
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist