Show redirect_to_base config in store scope #13614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JeroenVanLeusden
force-pushed
the
patch-7
branch
from
f9e7c28 to
0cb7019
Compare
|
Hi @JeroenVanLeusden thanks for this PR. I will process this now for you. |
This was referenced Feb 14, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 15, 2018
paales
added
Partner: Reach Digital
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
web/unsecure/base_urlconfig to website and store scope. Setting is used that way in the code, see:https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Store/App/FrontController/Plugin/RequestPreprocessor.php#L80-L83
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Store/Model/BaseUrlChecker.php#L63-L66
The tests also use store scope.
Fixed Issues (if relevant)
Related Pull Request
#13659
Contribution checklist