Skip to content

Show redirect_to_base config in store scope #13613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JeroenVanLeusden
Copy link
Member

@JeroenVanLeusden JeroenVanLeusden commented Feb 12, 2018

Description

Add web/unsecure/base_url config to website and store scope. Setting is used that way in the code, see:
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Store/App/FrontController/Plugin/RequestPreprocessor.php#L80-L83
https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Store/Model/BaseUrlChecker.php#L63-L66

The tests also use store scope.

Fixed Issues (if relevant)

  1. None I could find.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@JeroenVanLeusden JeroenVanLeusden deleted the JeroenVanLeusden-patch-1 branch February 12, 2018 14:27
@JeroenVanLeusden
Copy link
Member Author

Wrong source branch, please see #13614

@paales paales added Partner: Reach Digital Pull Request is created by partner Reach Digital and removed Partner: Reach Digital Pull Request is created by partner Reach Digital labels May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Reach Digital Pull Request is created by partner Reach Digital Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants