Skip to content

[Backport to 2.3-develop] Fix #11236: Web Setup Wizard Icon Inconsistency #12960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2018
Merged

[Backport to 2.3-develop] Fix #11236: Web Setup Wizard Icon Inconsistency #12960

merged 1 commit into from
Jan 3, 2018

Conversation

@dverkade
Copy link
Member

@dverkade dverkade commented Jan 2, 2018

Fix #11236:

  • Changed side-menu.phtml to have naming in line with the naming in home.phtml. Component was the name in prior to Magento 2.2
  • Updated the less files to reflect these changes and switched the icons in the menu
  • Updated compiled setup.css file

Backport

Backport of this PR: #11388

@dverkade
Fix #11236:
8cb5b9c 
- Changed side-menu.phtml to have naming in line with the naming in home.phtml. Component was the name in < Magento 2.2
- Updated the less files to reflect these changes and switched the icons in the menu
- Updated compiled setup.css file
@magento-engcom-team magento-engcom-team added Fixed in 2.2.x The issue has been fixed in 2.2 release line Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release SQUASHTOBERFEST labels Jan 2, 2018
@dmanners dmanners self-assigned this Jan 3, 2018
@dmanners dmanners added this to the January 2018 milestone Jan 3, 2018
@magento-team magento-team mentioned this pull request Jan 3, 2018
Closed
@magento-team magento-team merged commit 8cb5b9c into magento:2.3-develop Jan 3, 2018
magento-team pushed a commit that referenced this pull request Jan 3, 2018
@ishakhsuvarov
MAGETWO-86276: [Backport to 2.3-develop] Fix #11236: Web Setup Wizard…
be380e2 
… Icon Inconsistency #12960
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 3, 2018
@dverkade dverkade deleted the 2.3-Web-Setup-Wizard-Icon-Inconsistency branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dmanners dmanners dmanners approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dmanners dmanners

Labels

Community Insider: Cream community-insider-contribution Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.3 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

January 2018

Development

Successfully merging this pull request may close these issues.

4 participants

@dverkade @dmanners @magento-team @magento-engcom-team