Skip to content

Fix #11236: Web Setup Wizard Icon Inconsistency #11388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2017
Merged

Fix #11236: Web Setup Wizard Icon Inconsistency #11388

merged 1 commit into from
Dec 1, 2017

Conversation

@dverkade
Copy link
Member

@dverkade dverkade commented Oct 11, 2017

Fix #11236:

  • Changed side-menu.phtml to have naming in line with the naming in home.phtml. Component was the name in prior to Magento 2.2
  • Updated the less files to reflect these changes and switched the icons in the menu
  • Updated compiled setup.css file

@dverkade
Fix #11236:
ccb38ab 
- Changed side-menu.phtml to have naming in line with the naming in home.phtml. Component was the name in < Magento 2.2
- Updated the less files to reflect these changes and switched the icons in the menu
- Updated compiled setup.css file
@dverkade
Copy link
Member Author

dverkade commented Oct 11, 2017

Please note that there is a similar PR under #11346

@dverkade dverkade mentioned this pull request Oct 11, 2017
Closed
4 tasks
@vrann vrann self-assigned this Oct 12, 2017
@vrann vrann added this to the October 2017 milestone Oct 12, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on develop labels Nov 7, 2017
@okorshenko okorshenko assigned okorshenko and unassigned vrann Nov 28, 2017
@okorshenko okorshenko merged commit ccb38ab into magento:2.2-develop Dec 1, 2017
okorshenko pushed a commit that referenced this pull request Dec 1, 2017
MAGETWO-81740: Fix #11236: Web Setup Wizard Icon Inconsistency #11388
c384e0d
@magento-engcom-team magento-engcom-team added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Dec 1, 2017
@dverkade dverkade mentioned this pull request Jan 2, 2018
Merged
@dverkade dverkade deleted the Web_Setup_Wizard_Icon_Inconsistency branch June 22, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@okorshenko okorshenko

Labels

Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Projects

None yet

Milestone

November 2017

Development

Successfully merging this pull request may close these issues.

5 participants

@dverkade @magento-team @vrann @okorshenko @magento-engcom-team