Fix for #4530 $product->getRatingSummary() always returns null […] #10248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
magento-team
pushed a commit
that referenced
this pull request
Jul 18, 2017
magento-team
pushed a commit
that referenced
this pull request
Jul 18, 2017
[EngCom] Public Pull Requests - MAGETWO-70817: remove redundant else and use strict check #10271 - MAGETWO-70787: update phpserver to support versioned static urls #10250 - MAGETWO-70764: Fix overwrite default value image/file with NULL #10253 - MAGETWO-70761: Show values that are duplicate in attribute error msg #10213 - MAGETWO-70758: Fix for #4530 $product->getRatingSummary() always returns null […] #10248 - MAGETWO-70706: simplify product lists #2 #9019 - MAGETWO-70669: Fix fatal errors with deleteOptionsAndSelections #7711 - MAGETWO-70464: Fix shipping address can use for billing #10130 - MAGETWO-69913: magento/magento2 #9196 - Products ordered report doesn't show simple (child) products of configurable products #9908
magento-team
pushed a commit
that referenced
this pull request
Oct 7, 2017
…) always returns null […] #10248 - for 2.2
magento-team
pushed a commit
that referenced
this pull request
Oct 7, 2017
…) always returns null […] #10248 - for 2.2 - fix after CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
\Magento\Review\Block\Product\ReviewRenderersuch that the reviews summary is shown although$displayIfNoReviewsis set tofalseand reviews are in fact available.Description
Always retrieve relevant data before checking whether there are active reviews if
$displayIfNoReviewsis set tofalse.Fixed Issue
#4530: $product->getRatingSummary() always returns null on products with ratings
Manual testing scenario
Change the last parameter
$displayIfNoReviewsin the\Magento\Review\Block\Product\ReviewRenderer::getReviewsSummaryHtmlmethod call tofalsesuch that the call in the templateapp/code/Magento/Catalog/view/frontend/templates/product/view/review.phtmllooks like thisIn both cases (No reviews available/at least one review is available) the reviews summary won't be shown. After applying this PR the reviews summary will be shown as expected only if there is at least one review available.
Contribution checklist